dev/core#2823 Extract code to load the declarations and call from the constructor #21399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
changed the title
As the code comments suggest the handling of a module being unrecognised sould be handled in the validate not the enable function
… constructor The declarations are only used in object context so it makes sense to load them in the constructor. In addition they are ALWAYS loaded except in test usage (it does seem a bit silly having the option to pass them in only for tests but we can ignore that for now - I commented it)
eileenmcnaughton
force-pushed
the
mgd
branch
from
298d0fb to
78ce6eb
Compare
|
This passes unit tests so it must be ok, but it's strange that #21401 fails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
dev/core#2823 Extract code to load the declarations and call from the constructor
Before
declarations are loaded in
getDeclarationsif not already loaded. However, there is also code to load them in the constructor which makes is confusingAfter
Always loaded in the constructor
Technical Details
The declarations are only used in object context so it makes sense to load
them in the constructor and they are always needed in usage of this class.
In addition they are ALWAYS loaded (rather than passed in) except in test usage
(it does seem a bit silly having the option to pass them in only for tests
but we can ignore that for now - I commented it)
Comments